Add nvm and Node provisioning to the-vagrant #56
Conversation
There was a problem hiding this comment.
This worked great for me and looks like a simple way to manage Node in the vagrant on projects. I did test one case where I updated the-vagrant and ran vagrant reload --provision without running the-vagrant-installer and was greeted with an error:
ERROR! the role 'leanbit.nvm' was not found in /Users/byronduvall/ntc/vendor/palantirnet/the-vagrant/conf/vagrant/provisioning/roles:/Users/byronduvall/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles:/Users/byronduvall/ntc/vendor/palantirnet/the-vagrant/conf/vagrant/provisioning
The error appears to have been in '/Users/byronduvall/ntc/vendor/palantirnet/the-vagrant/conf/vagrant/provisioning/drupal8-skeleton.yml': line 18, column 7, but may
be elsewhere in the file depending on the exact syntax problem.
The offending line appears to be:
- { role: gulp }
- { role: leanbit.nvm,
^ here
Do developers normally re-run the installer when upgrading the-vagrant on a project (and risk losing their customizations), or should this be able to handle the situations where the installer isn't run?
|
This PR adds the We talked about this last week, and determined that we should save this PR for a minute and create the 2.3 release after merging it. |
Completes ZRAD-118 - Add nvm/node provisioning to the-vagrant.
To test:
composer require --dev palantirnet/the-vagrant:dev-nvm-node-provisioningvendor/bin/the-vagrant-installergit diffvagrant up --provisionorvagrant reload --provisionnvm --version(should be0.33.11)node --version(should be whatever you entered when you installed)Open questions: